Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for report setting on analytics #1836

Merged
merged 16 commits into from
Jul 13, 2023
Merged

Conversation

VineetBala-AOT
Copy link
Collaborator

Description of changes:

  • Changes to include questions with the display as null on the dashboard
  • Refactor code to do an bulk update or delete operation instead of in a loop

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #1836 (b434010) into main (b34ac34) will increase coverage by 0.61%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##             main    #1836      +/-   ##
==========================================
+ Coverage   71.47%   72.08%   +0.61%     
==========================================
  Files         396      428      +32     
  Lines       12051    12679     +628     
  Branches      910      910              
==========================================
+ Hits         8613     9140     +527     
- Misses       3291     3392     +101     
  Partials      147      147              
Flag Coverage Δ
analyticsapi 83.30% <100.00%> (?)
metapi 79.23% <40.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
met-api/src/met_api/models/report_setting.py 79.06% <37.50%> (-5.15%) ⬇️
...api/src/met_api/services/report_setting_service.py 67.44% <42.85%> (+5.48%) ⬆️
...pi/src/analytics_api/models/request_type_option.py 68.75% <100.00%> (ø)

... and 31 files with indirect coverage changes

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review July 13, 2023 18:21
@VineetBala-AOT VineetBala-AOT merged commit 98110d6 into bcgov:main Jul 13, 2023
16 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* updates on engagement publish

* update email template

* adding action drop down

* updated changes for User Management

* access user details page for users without a role

* updating variable name

* updating the schema

* updating as per review comments

* updating schema

* ETL and analytics changes for report setting

* adding changes for clone and delete

* fixing linting

* front end and etl changes for postion column

* update

* fix for report setting on analytics

* fixing lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants